Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WifiWave2. #226

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

ytimenkov
Copy link
Contributor

Added configuration profiles to configure Mikrotik APs which have only WifiWave2 package.

SUMMARY

New Access Points like capAX don't have support for the previous "wireless" module and shipped only with WifiWave 2.
This Pull Requests adds some settings to enable configuring such APs with ansible.

ADDITIONAL INFORMATION

Documentation and parameters can be found in the Mikrotiks wiki: https://help.mikrotik.com/docs/display/ROS/WifiWave2

Current settings are more profile-based. I.e. the expectation is to create (say) channel profile and then use it further.
However Mikrotik allows specifying all options "in-place" or override ones coming from profile:

        path: interface wifiwave2 security
        data:
          - name: lan-auth
            authentication-types: wpa2-psk,wpa3-psk
...
        path: interface wifiwave2 configuration
        data:
          - name: lan-conf
            security: lan-auth

vs

        path: interface wifiwave2 configuration
        data:
          - name: lan-conf
            security.authentication-types: wpa2-psk,wpa3-psk

The latter is not implemented, but I can add it if required.

@github-actions
Copy link

github-actions bot commented Sep 30, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac89aa0) 82.92% compared to head (103efe1) 82.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   82.92%   82.97%   +0.04%     
==========================================
  Files          32       32              
  Lines        4046     4046              
  Branches      871      871              
==========================================
+ Hits         3355     3357       +2     
  Misses        506      506              
+ Partials      185      183       -2     
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.10% <100.00%> (+0.09%) ⬆️
units 82.91% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixfontein
Copy link
Collaborator

Hmm, I know to little about that endpoint (and don't have enough time right now to read into it) to be able to answer your question, but I guess this needs some more thought.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not writing back earlier. I've been able to ask @derdeagle for some feedback on this. His suggestions was to version it (see my comment below), and to potentially also implement more related paths (interface wifiwave2 access-list, interface wifiwave2 provisioning, interface wifiwave2 capsman, interface wifiwave2 cap) - but that could also happen later (i.e. outside this PR).

plugins/module_utils/_api_data.py Outdated Show resolved Hide resolved
plugins/modules/api_modify.py Outdated Show resolved Hide resolved
plugins/module_utils/_api_data.py Outdated Show resolved Hide resolved
Added configuration profiles to configure Mikrotik APs which
have only WifiWave2 package.
1. Sorted lexicographically new entries
2. Added versioning
According to the documentation, new RouterOS version uses another
package.
changelogs/fragments/226-support-for-WifiWave2.yml Outdated Show resolved Hide resolved
plugins/modules/api_modify.py Outdated Show resolved Hide resolved
plugins/module_utils/_api_data.py Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit c5e51f9 into ansible-collections:main Dec 14, 2023
45 checks passed
@felixfontein
Copy link
Collaborator

@ytimenkov thanks a lot for your contribution!
@derdeagle thanks a lot for reviewing this!

And sorry this took so long...

@ytimenkov ytimenkov deleted the wifiwave2-paths branch December 30, 2023 10:26
@cosandr cosandr mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants