Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #193: Add caps-man channel and caps-man manager interface #194

Conversation

derdeagle
Copy link
Contributor

Adding the caps-man channel path from scratch.
Activating the caps-man manager interface path.

SUMMARY

Fixes #193.

Adding the caps-man channel path from scratch.
Activating the caps-man manager interface path.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify
ADDITIONAL INFORMATION

None.

…ger interface

Adding the caps-man channel path from scratch.
Activating the caps-man manager interface path.
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #194 (7a91abf) into main (d6f90e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          32       32           
  Lines        3850     3850           
  Branches      801      801           
=======================================
  Hits         3256     3256           
  Misses        456      456           
  Partials      138      138           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.23% <ø> (ø)
units 84.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/module_utils/_api_data.py 96.92% <ø> (ø)
plugins/modules/api_info.py 90.14% <ø> (ø)
plugins/modules/api_modify.py 77.65% <ø> (ø)

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long, I was on vacation and had no access to a MikroTik router ;)

@felixfontein felixfontein merged commit 53bb84b into ansible-collections:main Aug 12, 2023
@felixfontein
Copy link
Collaborator

@derdeagle thanks!

@derdeagle
Copy link
Contributor Author

Thank you very much! No problem at all, it's on a voluntary basis so any time spent is appreciated ;)
By the way do you see any chance that we talk about this project and how MikroTik adds new parameters etc.? I already worked (locally) on the next changes for BGP stuff. If so please tell me how I can reach you.

@derdeagle derdeagle deleted the add_caps-man_channel_and_caps-man_manager_interface branch August 12, 2023 14:17
@felixfontein
Copy link
Collaborator

I'm usually on Matrix in #community:ansible.com and on Libera IRC in #ansible-community. Depending on what you want to discuss starting a new issue in this repository might also be a good place for such a discussion, that way other interested parties can more easily weight in as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "caps-man channel" and enable "caps-man manager interface" paths
2 participants