Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #191: Add path 'ip traffic-flow target' #192

Conversation

derdeagle
Copy link
Contributor

SUMMARY

Adding the path ip traffic-flow target with the default values I could find.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify
ADDITIONAL INFORMATION

None.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #192 (66dd67e) into main (e570c58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          32       32           
  Lines        3850     3850           
  Branches      801      801           
=======================================
  Hits         3256     3256           
  Misses        456      456           
  Partials      138      138           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.23% <ø> (ø)
units 84.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 96.92% <ø> (ø)
plugins/modules/api_info.py 90.14% <ø> (ø)
plugins/modules/api_modify.py 77.65% <ø> (ø)

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

…as it is only adding a path and neither breaking existing things nor adding completely new functionality
@felixfontein felixfontein merged commit 6e62283 into ansible-collections:main Jul 23, 2023
@felixfontein
Copy link
Collaborator

@derdeagle thanks a lot!

@derdeagle
Copy link
Contributor Author

@felixfontein Thank you, for keeping this project up and reviewing thoroughly ;)

@derdeagle derdeagle deleted the add_ip_traffic-flow_target_path branch July 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants