Fixes #179: Add missing /tool/e-mail parameter "tls" #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the [documentation](https://help.mikrotik.com/docs/display/ROS/E-mail#Email-Properties) the parameter "tls" is mentioned but it cannot be used. The old "start-tls" parameter is not mentioned there (only on the [old documentation](https://wiki.mikrotik.com/wiki/Manual:Tools/email#Properties)). Trying to use the paramter "tls" lead to the erro message `FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}`.
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 32 32
Lines 3850 3850
Branches 710 710
=======================================
Hits 3256 3256
Misses 456 456
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Thanks for your contribution! Could you please add a changelog fragment? Thanks.
|
Thanks for reviewing and sorry I missed that. I have added the changelog fragment. |
No worries, that's what reviews are for :) |
As suggested by felixfontein Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Jun 18, 2023
|
@derdeagle thanks for your contribution! |
|
@felixfontein Thank you, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #179: Add missing /tool/e-mail parameter "tls"
In the
documentation the parameter "tls" is mentioned but it cannot be used. The old "start-tls" parameter is not mentioned there (only on the old documentation). Trying to use the paramter "tls" lead to the erro message
FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}.ISSUE TYPE
COMPONENT NAME
community.routeros.api_modify
ADDITIONAL INFORMATION
None.