Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dashes in username #18

Merged
merged 4 commits into from
Dec 24, 2020
Merged

feat: support dashes in username #18

merged 4 commits into from
Dec 24, 2020

Conversation

heuels
Copy link
Collaborator

@heuels heuels commented Dec 23, 2020

SUMMARY

Fixes #17.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

community.routeros.command, community.routeros.facts

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #18 (3dec167) into main (b322351) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   82.91%   82.91%           
=======================================
  Files           9        9           
  Lines        1124     1124           
  Branches      149      149           
=======================================
  Hits          932      932           
  Misses        131      131           
  Partials       61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b322351...3dec167. Read the comment docs.

@heuels heuels requested a review from felixfontein December 23, 2020 19:13
Co-authored-by: Felix Fontein <[email protected]>
@heuels heuels merged commit 389924b into main Dec 24, 2020
@heuels heuels deleted the feat/dash-in-username branch December 24, 2020 11:46
@heuels
Copy link
Collaborator Author

heuels commented Dec 24, 2020

@felixfontein, thanks for reviewing!

@felixfontein
Copy link
Collaborator

@heuels should we do another release (1.0.2), or a wait a bit? The next Ansible release should be on January 5th, so we should definitely release before that, but we can also wait until January 4th :)

@heuels
Copy link
Collaborator Author

heuels commented Dec 24, 2020

@felixfontein, let's wait a bit — I just remembered I have #8 to fix. I'll be able to do it this week and after that I guess nothing is stopping us from releasing 1.0.2 🙂

@felixfontein
Copy link
Collaborator

@heuels would be 1.1.0 though since this is a feature PR, not a bugfix PR

@felixfontein
Copy link
Collaborator

@heuels any news on #8? Otherwise I'll make a 1.1.0 release with what we have now tomorrow.

@heuels
Copy link
Collaborator Author

heuels commented Jan 4, 2021

@felixfontein, sorry, I'm missing all the deadlines 😞

@felixfontein
Copy link
Collaborator

@heuels no problem! We'll just do another release once #8 is fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with community.routeros.command and community.routeros.facts when there is a dash in the username
2 participants