Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facts: fix bug in preprocessing when wrapped line is appended to a non-existing entry #177

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #170.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

facts

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #177 (bba5bac) into main (2b8c66b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          32       32           
  Lines        3850     3850           
  Branches      710      710           
=======================================
  Hits         3256     3256           
  Misses        456      456           
  Partials      138      138           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.23% <0.00%> (ø)
units 84.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/facts.py 83.00% <100.00%> (ø)

@felixfontein felixfontein merged commit 42ea132 into ansible-collections:main Jun 9, 2023
@felixfontein felixfontein deleted the preprocess branch June 9, 2023 04:03
@felixfontein
Copy link
Collaborator Author

Thanks a lot for reviewing @briantist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community.routeros.facts not working for MikroTik RouterOS 7.9
2 participants