Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .id restriction for list_to_dic #15

Merged
merged 3 commits into from
Dec 10, 2020
Merged

remove .id restriction for list_to_dic #15

merged 3 commits into from
Dec 10, 2020

Conversation

NikolayDachev
Copy link
Collaborator

SUMMARY

Remove .id restriction, we have separate checks already (where is needed)
Fixes #13

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.routeros.api

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #15 (d7e9b0f) into main (649809b) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   82.77%   82.91%   +0.14%     
==========================================
  Files           9        9              
  Lines        1126     1124       -2     
  Branches      150      149       -1     
==========================================
  Hits          932      932              
+ Misses        132      131       -1     
+ Partials       62       61       -1     
Impacted Files Coverage Δ
plugins/modules/api.py 75.28% <ø> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649809b...d7e9b0f. Read the comment docs.

@NikolayDachev
Copy link
Collaborator Author

NikolayDachev commented Dec 9, 2020

@heuels @felixfontein Actually I'm not sure for change log and if we should bump the version

@felixfontein
Copy link
Collaborator

@NikolayDachev don't wory about the version, I'll handle that during the release process. I can make a 1.0.1 patch release after this is merged, since we don't have anything waiting that would require a minor release.

About changelog fragment: simply create one describing this bugfix, the general instructions on how they should look like are here: https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to

Copy link
Collaborator

@heuels heuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@felixfontein
Copy link
Collaborator

@heuels @NikolayDachev I'll create a new release for the collection somewhen tomorrow or over the weekend.

Feel free to merge this once tests pass, otherwise I'll do it tomorrow. I'm off to bed now ;)

@NikolayDachev NikolayDachev merged commit 6c618ca into ansible-collections:main Dec 10, 2020
@NikolayDachev NikolayDachev deleted the issue#13 branch December 10, 2020 21:45
@felixfontein felixfontein mentioned this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/tool romon set id conflict with api .id
3 participants