-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove .id restriction for list_to_dic #15
remove .id restriction for list_to_dic #15
Conversation
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 82.77% 82.91% +0.14%
==========================================
Files 9 9
Lines 1126 1124 -2
Branches 150 149 -1
==========================================
Hits 932 932
+ Misses 132 131 -1
+ Partials 62 61 -1
Continue to review full report at Codecov.
|
@heuels @felixfontein Actually I'm not sure for change log and if we should bump the version |
@NikolayDachev don't wory about the version, I'll handle that during the release process. I can make a 1.0.1 patch release after this is merged, since we don't have anything waiting that would require a minor release. About changelog fragment: simply create one describing this bugfix, the general instructions on how they should look like are here: https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Co-authored-by: Felix Fontein <[email protected]>
@heuels @NikolayDachev I'll create a new release for the collection somewhen tomorrow or over the weekend. Feel free to merge this once tests pass, otherwise I'll do it tomorrow. I'm off to bed now ;) |
SUMMARY
Remove .id restriction, we have separate checks already (where is needed)
Fixes #13
ISSUE TYPE
COMPONENT NAME
community.routeros.api