Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple api paths support and updates #131

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

therfert
Copy link
Contributor

SUMMARY

new features:

  • support API paths ipv6 address, ipv6 dhcp-server, ipv6 dhcp-server option, ipv6 route, queue tree, routing ospf area, routing ospf area range, routing ospf instance, routing ospf interface-template, routing pimsm instance, routing pimsm interface-template
  • support for fields blackhole, pref-src, routing-table, suppress-hw-offload, type, vrf-interface in ip route path

bugfixes:

  • queue interface path works with api_modify now
  • ip route entry can be defined wihtout the need of gateway field (which is correct for unreachable/blackhole type of routes).
ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify
ADDITIONAL INFORMATION

none

Signed-off-by: Tomas Herfert <herfik>
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #131 (aefc31a) into main (c48f4c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main     #131    +/-   ##
========================================
  Coverage   87.56%   87.56%            
========================================
  Files          28       28            
  Lines        3499     3499            
  Branches      619      516   -103     
========================================
  Hits         3064     3064            
  Misses        308      308            
  Partials      127      127            
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.45% <ø> (ø)
units 87.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 95.91% <ø> (ø)
plugins/modules/api_info.py 89.23% <ø> (ø)
plugins/modules/api_modify.py 79.90% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Tomas Herfert added 2 commits November 14, 2022 22:04
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
@therfert therfert marked this pull request as ready for review November 14, 2022 21:30
@therfert
Copy link
Contributor Author

Hi @felixfontein, do you prefer such PR or rather multiple smaller ones as I've been doing before?

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly editorial changes to the changelog :)

changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
changelogs/fragments/131-api.yml Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

Hi @felixfontein, do you prefer such PR or rather multiple smaller ones as I've been doing before?

It depends, changes such as #128 and #130 definitely should be their own PR, but others like this can be combined.

@felixfontein felixfontein merged commit 4194ae9 into ansible-collections:main Nov 15, 2022
@felixfontein
Copy link
Collaborator

@therfert thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants