Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_modify, api_info: support more fields in existing paths #121

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #115.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

api_modify
api_info

@felixfontein
Copy link
Collaborator Author

@therfert if you're interested in reviewing a similar PR... :)

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #121 (c0ec761) into main (c2e58c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   87.64%   87.64%           
=======================================
  Files          28       28           
  Lines        3496     3496           
  Branches      618      618           
=======================================
  Hits         3064     3064           
  Misses        305      305           
  Partials      127      127           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.48% <ø> (ø)
units 87.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 95.91% <ø> (ø)
tests/unit/plugins/modules/test_api_info.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

plugins/module_utils/_api_data.py Outdated Show resolved Hide resolved
plugins/module_utils/_api_data.py Outdated Show resolved Hide resolved
Copy link
Contributor

@therfert therfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@felixfontein felixfontein merged commit 9fc22be into ansible-collections:main Nov 10, 2022
@felixfontein felixfontein deleted the paths branch November 10, 2022 20:10
@felixfontein
Copy link
Collaborator Author

@therfert thanks for reviewing this!

@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api_modify unsupported keys
2 participants