Skip to content

Commit

Permalink
Fixes #230: Add missing DoH parameters in the "ip dns" path (#235)
Browse files Browse the repository at this point in the history
- doh-max-concurrent-queries
- doh-max-server-connections
- doh-timeout

The parameters mentioned above seem to be added in version 7.8 as far as
I could tell from the changelogs.

Co-authored-by: Johannes Münch <[email protected]>
  • Loading branch information
derdeagle and derdeagle authored Nov 24, 2023
1 parent 92c6226 commit dac3b79
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/235-add-missing-dns-attributes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- api_info, api_modify - add missing DoH parameters ``doh-max-concurrent-queries``, ``doh-max-server-connections``, and ``doh-timeout`` to the ``ip dns`` path (https://github.com/ansible-collections/community.routeros/issues/230, https://github.com/ansible-collections/community.routeros/pull/235)
5 changes: 5 additions & 0 deletions plugins/module_utils/_api_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,11 @@ def join_path(path):
unversioned=VersionedAPIData(
single_value=True,
fully_understood=True,
versioned_fields=[
([('7.8', '>=')], 'doh-max-concurrent-queries', KeyInfo(default=50)),
([('7.8', '>=')], 'doh-max-server-connections', KeyInfo(default=5)),
([('7.8', '>=')], 'doh-timeout', KeyInfo(default='5s')),
],
fields={
'allow-remote-requests': KeyInfo(),
'cache-max-ttl': KeyInfo(default='1w'),
Expand Down

0 comments on commit dac3b79

Please sign in to comment.