Prepare 3.0.0 release.

ansible-collections · Sep 24, 2024 · 269dc9c · 269dc9c
1 parent c864078
commit 269dc9c
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 44 deletions.
diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml
@@ -26,12 +26,6 @@ jobs:
         ansible:
           # It's important that Sanity is tested against all stable-X.Y branches
           # Testing against `devel` may fail as new tests are added.
-          - stable-2.9
-          - stable-2.10
-          - stable-2.11
-          - stable-2.12
-          - stable-2.13
-          - stable-2.14
           - stable-2.15
           - stable-2.16
           - stable-2.17
@@ -75,13 +69,6 @@ jobs:
       fail-fast: true
       matrix:
         ansible:
-          - stable-2.9
-          - stable-2.10
-          - stable-2.11
-          - stable-2.12
-          - stable-2.13
-          - stable-2.14
-          - stable-2.15
           - stable-2.16
           - stable-2.17
           - stable-2.18
@@ -122,41 +109,24 @@ jobs:
           - "3.10"
           - "3.11"
           - "3.12"
+          - "3.13"
         include:
-          # 2.9
-          - ansible: stable-2.9
-            python: 2.7
-          - ansible: stable-2.9
-            python: 3.5
-          # 2.10
-          - ansible: stable-2.10
-            python: 3.5
-          # 2.11
-          - ansible: stable-2.11
-            python: 2.7
-          - ansible: stable-2.11
-            python: 3.6
-          # 2.12
-          - ansible: stable-2.12
-            python: 3.8
-          # 2.13
-          - ansible: stable-2.13
-            python: "3.10"
-          # 2.14
-          - ansible: stable-2.14
-            python: "3.11"
           # 2.15
           - ansible: stable-2.15
-            python: "3.9"
+            python: "2.7"
+          - ansible: stable-2.15
+            python: "3.6"
+          - ansible: stable-2.15
+            python: "3.7"
           # 2.16
           - ansible: stable-2.16
             python: "3.10"
           # 2.17
           - ansible: stable-2.17
-            python: "3.7"
+            python: "3.8"
           # 2.18
           - ansible: stable-2.18
-            python: "3.8"
+            python: "3.9"
 
     steps:
       - name: >-

diff --git a/README.md b/README.md
@@ -33,7 +33,7 @@ For more information about communication, see the [Ansible communication guide](
 
 ## Tested with Ansible
 
-Tested with the current Ansible 2.9, ansible-base 2.10, ansible-core 2.11, ansible-core 2.12, ansible-core 2.13, ansible-core 2.14, ansible-core 2.15, ansible-core 2.16, ansible-core 2.17, and ansible-core 2.18 releases and the current development version of ansible-core. Ansible versions before 2.9.10 are not supported.
+Tested with the current ansible-core 2.15, ansible-core 2.16, ansible-core 2.17, and ansible-core 2.18 releases and the current development version of ansible-core. Ansible 2.9, ansible-base 2.10, and ansible-core versions before 2.15.0 are not supported.
 
 ## External requirements
 

diff --git a/changelogs/fragments/3.0.0.yml b/changelogs/fragments/3.0.0.yml
@@ -0,0 +1,7 @@
+release_summary: Major release that drops support for End of Life Python versions and fixes check mode for community.routeros.command.
+removed_features:
+  - "The collection no longer supports Ansible 2.9, ansible-base 2.10, ansible-core 2.11, ansible-core 2.12, ansible-core 2.13, and ansible-core 2.14.
+     If you need to continue using End of Life versions of Ansible/ansible-base/ansible-core, please use community.routeros 2.x.y
+     (https://github.com/ansible-collections/community.routeros/pull/318)."
+breaking_changes:
+  - "command - the module no longer declares that it supports check mode (https://github.com/ansible-collections/community.routeros/pull/318)."
diff --git a/galaxy.yml b/galaxy.yml
@@ -7,7 +7,7 @@
 
 namespace: community
 name: routeros
-version: 2.19.0
+version: 3.0.0
 readme: README.md
 authors:
   - Egor Zaitsev (github.com/heuels)

diff --git a/meta/runtime.yml b/meta/runtime.yml
@@ -3,7 +3,7 @@
 # GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
 # SPDX-License-Identifier: GPL-3.0-or-later
 
-requires_ansible: '>=2.9.10'
+requires_ansible: '>=2.15.0'
 action_groups:
   api:
     - api

diff --git a/plugins/modules/command.py b/plugins/modules/command.py
@@ -27,9 +27,10 @@
   - community.routeros.attributes
 attributes:
   check_mode:
-    support: partial
+    support: none
     details:
-      - The module claims to support check mode, but it simply always executes the command.
+      - Before community.routeros 3.0.0, the module claimed to support check mode.
+        It simply executed the command in check mode.
   diff_mode:
     support: none
   platform:
@@ -165,7 +166,7 @@ def main():
     argument_spec.update(routeros_argument_spec)
 
     module = AnsibleModule(argument_spec=argument_spec,
-                           supports_check_mode=True)
+                           supports_check_mode=False)
 
     result = {'changed': False}