Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection CI related actions needed #137

Closed
Andersson007 opened this issue Sep 26, 2022 · 3 comments · Fixed by #139
Closed

Collection CI related actions needed #137

Andersson007 opened this issue Sep 26, 2022 · 3 comments · Fixed by #139

Comments

@Andersson007
Copy link
Contributor

SUMMARY

Relates to ansible-collections/news-for-maintainers#24.

It's been detected that this repository contains ignore-2.14.txt file but not ignore-2.15.txt file.

Actions needed:

  • Copy tests/sanity/ignore-2.14.txt to tests/sanity/ignore-2.15.txt otherwise the CI will get failing.
  • If it's not done yet, add the stable-2.15 branch to your CI workflow files. If you use GitHub actions, see the content of .github/workflows or, if you use Azure Pipelines, community.postgresql/.azure-pipelines/azure-pipelines.yml. If not added, this will violate the Collection Requirements for collections included in the Ansible package.
  • Subscribe to and track the news-for-maintainers repository if you're not subscribed yet.
  • If it's not relevant for this repo, just close the issue.

To read more about the topic, see the Ignores guide.

To read more about the context, see the announcement.

Thank you!
csmart added a commit to csmart/community.rabbitmq that referenced this issue Sep 27, 2022
@csmart
CI: create ignore-2.15 file to prevent CI from failing
db5f656 
Fixes ansible-collections#137
csmart added a commit to csmart/community.rabbitmq that referenced this issue Oct 5, 2022
@csmart
CI: add 2.14 tests, create ignore-2.15 to prevent CI failure
d8032b3 
Fixes ansible-collections#137
@csmart csmart mentioned this issue Oct 5, 2022
Merged
@Im0
Copy link
Collaborator

Im0 commented Oct 19, 2022

@csmart Is this still good to approve? I've not done much in the way of these CI files before so unsure of the impact, but, it does look reasonable.

@csmart
Copy link
Collaborator

csmart commented Oct 19, 2022

@Im0 oh thanks for the reminder! Let me check the PR, I think it was failing on Ubuntu tests...

csmart added a commit to csmart/community.rabbitmq that referenced this issue Oct 19, 2022
@csmart
CI: add 2.14 tests, create ignore-2.15 to prevent CI failure
737779c 
Fixes ansible-collections#137
@Im0
Copy link
Collaborator

Im0 commented Oct 20, 2022

If it is, please check and maybe approve #141

@Im0 Im0 closed this as completed in #139 Oct 31, 2022
Im0 added a commit that referenced this issue Oct 31, 2022
@csmart @Im0
CI: add 2.14 tests, create ignore-2.15 to prevent CI failure (#139)
ebf9d99 
* CI: add 2.14 tests, create ignore-2.15 to prevent CI failure

Fixes #137

Co-authored-by: John Imison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: add 2.14 tests, create ignore-2.15 to prevent CI failure csmart/community.rabbitmq
3 participants
@csmart @Im0 @Andersson007