Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeswitch): allow to differentiate between running and startup config #105

Merged
merged 10 commits into from
Sep 3, 2020
Merged

feat(edgeswitch): allow to differentiate between running and startup config #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ca17086
feat(config): allow to differentiate between running and startup config
mrwiora Aug 26, 2020
7a045c0
fix(edgeswitch): ensuring backward compatibility - runningconfig rema…
mrwiora Aug 27, 2020
0e6a616
feat(changelog): adding version change info for startupconfig
mrwiora Aug 27, 2020
941a49e
fix(tests): ignore startupconfig as parameter
mrwiora Aug 28, 2020
054098d
fix(lint): satify linter - blank lines missmatch
mrwiora Aug 28, 2020
7f4e76d
Merge branch 'main' of github.com:mwiora/community.network into main
mrwiora Aug 28, 2020
835be4c
feat(changelog): adding changelog fragment
mrwiora Sep 2, 2020
c775a7f
fix(changelog): changelog fragment as required
mrwiora Sep 2, 2020
82d6f52
trigger(): retrigger
mrwiora Sep 2, 2020
55fa204
Update changelogs/fragments/105_edgeswitch_add-startupconfig.yml
mrwiora Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/105_edgeswitch_add-startupconfig.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- edgeswitch_facts - added ``startupconfig`` to facts module - to allow the comparision between startup and running config (https://github.com/ansible-collections/community.network/pull/105).
21 changes: 20 additions & 1 deletion plugins/modules/network/edgeswitch/edgeswitch_facts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,11 @@
community.network.edgeswitch_facts:
gather_subset: all

- name: Collect only the config and default facts
- name: Collect only the running config and default facts
community.network.edgeswitch_facts:
gather_subset:
- config

"""

RETURN = """
Expand Down Expand Up @@ -69,6 +70,12 @@
type: str

# config
ansible_net_startupconfig:
description: The startup config from the device
returned: when config is configured
type: str
mrwiora marked this conversation as resolved.
Show resolved Hide resolved
version_added: 1.2.0

ansible_net_config:
description: The current active config from the device
returned: when config is configured
Expand Down Expand Up @@ -148,6 +155,17 @@ def populate(self):
self.facts['config'] = data


class StartupConfig(FactsBase):

COMMANDS = ['show startup-config']

def populate(self):
super(StartupConfig, self).populate()
data = self.responses[0]
if data:
self.facts['startupconfig'] = data


class Interfaces(FactsBase):

COMMANDS = [
Expand Down Expand Up @@ -192,6 +210,7 @@ def parse_interfaces_status(self, data, interfaces):
FACT_SUBSETS = dict(
default=Default,
config=Config,
startupconfig=StartupConfig,
interfaces=Interfaces,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/plugins/modules/network/edgeswitch/test_edgeswitch_facts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def load_from_file(*args, **kwargs):
self.run_commands.side_effect = load_from_file

def test_edgeswitch_facts_default(self):
set_module_args(dict(gather_subset=['all', '!interfaces', '!config']))
set_module_args(dict(gather_subset=['all', '!interfaces', '!config', '!startupconfig']))
result = self.execute_module()
facts = result.get('ansible_facts')
self.assertEqual(len(facts), 5)
Expand Down