-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_db: added zstd
support
#696
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
- Coverage 79.54% 76.98% -2.56%
==========================================
Files 32 20 -12
Lines 2811 2664 -147
Branches 701 678 -23
==========================================
- Hits 2236 2051 -185
- Misses 395 415 +20
- Partials 180 198 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sergio-IME hi, thanks for the improvement!
I'm approving the PR as the implementation is the same as for the other formats.
Would be also great to add integration tests to somewhere in https://github.com/ansible-collections/community.mysql/tree/main/tests/integration/targets/test_mysql_db/tasks.
Would you be interested in doing it in another PR (or in this one if you want)?
Anyway, I don't see it as a blocker in this particular case.
Approved.
I don't think we test other compression algorithm either. So I'm merging this PR. Thanks @Sergio-IME for your contribution! |
a45a0d0
into
ansible-collections:main
Thank you so much for adding this @Sergio-IME 🙏 |
I think we could release after #697 if everybody is happy so user will get the features |
released https://galaxy.ansible.com/ui/repo/published/community/mysql FYI |
SUMMARY
Closes #594
Added support for zstd compressed dumps (
.zst
file extension), which can be faster and more efficient than the currently supported gzip/bz2/xz formats.ISSUE TYPE
COMPONENT NAME
mysql_db
ADDITIONAL INFORMATION