This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
helm - remove trailing whitespaces (#337) #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add remove_trailing_spaces() to remove trailing whitespaces for each helm_repository parameter
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 36.93% 36.93%
=======================================
Files 3 3
Lines 750 750
Branches 146 146
=======================================
Hits 277 277
Misses 424 424
Partials 49 49 Continue to review full report at Codecov.
|
* Add remove_trailing_spaces() to remove trailing whitespaces for each helm_repository parameter
* Add remove_trailing_spaces() to remove trailing whitespaces for each helm_repository parameter
* Add remove_trailing_spaces() to remove trailing whitespaces for each helm_repository parameter
* Add remove_trailing_spaces() to remove trailing whitespaces for each helm_repository parameter
* Add remove_trailing_spaces() to remove trailing whitespaces for each helm_repository parameter
goneri
approved these changes
Jan 14, 2021
|
Hi @alinabuzachis, Does this PR fix an existing opened issue? |
|
@goneri I has some reservations about this one. Isn't this breaking from convention to how Engine works? The rest of Ansible engine doesn't strip whitespace like this. We should be consistent with that and not introduce something that breaks with that convention because one person made a typo. |
goneri
added a commit
to goneri/community.kubernetes
that referenced
this pull request
Jan 14, 2021
|
Sorry, I understand. @tima I just pushed a PR to revert the patch. |
goneri
added a commit
that referenced
this pull request
Jan 14, 2021
This reverts commit 003d802. See: #345 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION