Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Replace KubernetesRawModule class #231

Merged
merged 2 commits into from
Sep 19, 2020

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Migrate from KubernetesRawModule to K8sAnsibleMixin
  • Modified k8s.py
  • Modified k8s_service.py

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/common.py
plugins/module_utils/raw.py
plugins/modules/k8s.py
plugins/modules/k8s_service.py

* Migrate from KubernetesRawModule to K8sAnsibleMixin
* Modified k8s.py
* Modified k8s_service.py

Signed-off-by: Abhijeet Kasurde <[email protected]>
Signed-off-by: Abhijeet Kasurde <[email protected]>
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #231 into main will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   42.50%   42.17%   -0.34%     
==========================================
  Files           4        3       -1     
  Lines         614      607       -7     
  Branches      122      122              
==========================================
- Hits          261      256       -5     
+ Misses        306      304       -2     
  Partials       47       47              
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 35.75% <0.00%> (-1.11%) ⬇️
...s/community/kubernetes/plugins/module_utils/raw.py
...ctions/community/kubernetes/plugins/modules/k8s.py 97.95% <0.00%> (+7.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51cadb7...93ea120. Read the comment docs.

Copy link
Collaborator

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we'll just have to remember to remove it in 2.0.0 😀

@tima
Copy link
Collaborator

tima commented Sep 19, 2020

@Akasurde Looks like you can merge this.

@Akasurde Akasurde merged commit 308956b into ansible-collections:main Sep 19, 2020
@Akasurde Akasurde deleted the k8s_raw_module_fix branch September 19, 2020 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants