-
Notifications
You must be signed in to change notification settings - Fork 104
Issue #40: Add changelog and fragments and document new changelog process. #131
Issue #40: Add changelog and fragments and document new changelog process. #131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 42.56% 42.56%
=======================================
Files 3 3
Lines 545 545
Branches 110 110
=======================================
Hits 232 232
Misses 270 270
Partials 43 43 Continue to review full report at Codecov.
|
Well that's annoying...
|
Why not simply having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from everything I can judge. I'm not sure whether listing new modules/plugins also in the major_changes
section is a good idea, but that's something you (as in c.k maintainers) have to decide for yourself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a little odd to have the new modules repeated in New Modules
and Major Changes
, but just a little
@fabianvf - Yeah... the thing is if I don't do that there's no changelog fragment and link back to the issue where the new module was added. |
I just realized the issue ID doesn't make its way into the changelog at all... @fabianvf - should we manually drop a reference into each of the fragments too? I like being able to click through from GitHub's rendered page to an issue if I want to check out the issue/PR that introduced the change. |
@geerlingguy the recommendation in https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to is to include a link to the issue and/or PR in the fragment itself. That way you can also click on it when the community.kubernetes changelog is viewed as a subset of the Ansible changelog. |
@geerlingguy yeah I definitely like the PR reference in the changelog. On the operator-sdk we wrote a tool that combines fragments and finds the PR# for the change based on the PR referenced in the commit that merged the changelog fragment I'd be happy to integrate it into this project if we wanted to (in the long-run we plan to split it out to its own project at which point we could just pull in the binary) |
@fabianvf - I think for now the idea is all the ACD/ I've updated all the fragments to include PR/issue links, and regenerated the changelog. It seems everything's now ready to go! Note: I didn't add any fragments for new issues/PRs merged since 0.11.0. That will (for now at least) be the responsibility of whomever tags the next release. |
Closes #40.