Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Issue #125: Add requires_ansible version constraints to runtime.yml. #126

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Issue #125: Add requires_ansible version constraints to runtime.yml. #126

merged 1 commit into from
Jun 16, 2020

Conversation

geerlingguy
Copy link
Collaborator

Closes #125.

Leaving in draft state until we can choose whether to set the minimum requirement to 2.9.10 vs 2.9 (see related issue).

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #126 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   42.88%   43.19%   +0.31%     
==========================================
  Files           3        3              
  Lines         541      544       +3     
  Branches      110      110              
==========================================
+ Hits          232      235       +3     
  Misses        266      266              
  Partials       43       43              
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 38.83% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46a5ee...e55053c. Read the comment docs.

@geerlingguy
Copy link
Collaborator Author

@codecov

n725075089_288918_2774

@geerlingguy geerlingguy marked this pull request as ready for review June 16, 2020 20:05
@geerlingguy
Copy link
Collaborator Author

From some discussions on IRC it seems that we're okay to go with 2.9 as the minimum version, since the content in this collection has been tested back that far.

@geerlingguy geerlingguy merged commit 9d46d7b into ansible-collections:master Jun 16, 2020
@geerlingguy geerlingguy deleted the 125-requires-ansible branch July 17, 2020 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'requires_ansible' requirements to collection
1 participant