k8s_exec should error if the process exit code isn't 0

[Yantrio]

SUMMARY

At the moment if you run k8s_exec and the command returns a non 0 status code the task still returns a successful change. I think it should return an error.

ISSUE TYPE

• Feature Idea

COMPONENT NAME

k8s_exec

ADDITIONAL INFORMATION

This could solve issues for playbooks where commands could possibly fail, and carry on unknowningly.

- name: Cause an exit code by using command 'false'
  community.kubernetes.k8s_exec:
    namespace: default
    pod: "mypodname"
    command: "false"

- name: This should never fire due to the error above
  .....

My python isn't too amazing, and I'm not familiar with the python kubernetes client, but it looks like we could utillize something similar to this https://github.com/kubernetes-client/python-base/pull/160/files in the part that parses the stream in k8s_exec here:

community.kubernetes/plugins/modules/k8s_exec.py

Lines 135 to 142 in 18dfb68

	while resp.is_open():
	resp.update(timeout=1)
	if resp.peek_stdout():
	stdout.append(resp.read_stdout())
	if resp.peek_stderr():
	stderr.append(resp.read_stderr())
	module.exit_json(
	changed=True, stdout="".join(stdout), stderr="".join(stderr))

Due to this being released already also, this may have to be behind a property as to not break existing functionality in playbooks out there already.

I may try at implementing this and I'll put in a PR if I'm successful.

[Akasurde]

@Yantrio I added rc in k8s_exec which returns the status code of the command, but this is changing the behavior of the module. Since we are rc affects ansible task status. Let me know if you want a toggle switch to enable this feature or not.

Thanks,