* Add changelog

* Address reviewer's comments * Add six in requirements.txt Signed-off-by: Alina Buzachis <[email protected]>
ansible-collections · Mar 31, 2021 · 1d3f2a9 · 1d3f2a9
1 parent aaaaff7
commit 1d3f2a9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/changelogs/fragments/405-cachefile_dynamic_client.yml b/changelogs/fragments/405-cachefile_dynamic_client.yml
@@ -0,0 +1,4 @@
+---
+ minor_changes:
+ - Add logic for cache file name generation (https://github.com/ansible-collections/community.kubernetes/pull/405).
+ - Add cache_file when DynamicClient is created (https://github.com/ansible-collections/community.kubernetes/pull/405).
diff --git a/plugins/module_utils/common.py b/plugins/module_utils/common.py
@@ -25,7 +25,6 @@
 import sys
 import six
 import hashlib
-import tempfile
 from datetime import datetime
 from distutils.version import LooseVersion
 
@@ -225,7 +224,7 @@ def generate_cache_file(configuration):
     cache_file = generate_cache_file(kubeclient)
 
     try:
-        client = DynamicClient(kubernetes.client.ApiClient(configuration), cache_file)
+        client = DynamicClient(kubeclient, cache_file)
     except Exception as err:
         _raise_or_fail(err, 'Failed to get client due to %s')
 

diff --git a/requirements.txt b/requirements.txt
@@ -1,2 +1,3 @@
 openshift>=0.6.2
 requests-oauthlib
+six