Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server_number options to firewall modules #77

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Identifying the server for firewalls by server main IP is deprecated (https://robot.hetzner.com/doc/webservice/en.html#get-firewall-server-id at the very bottom). This PR adds a server_number option that allows to identify the server by its identifier.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

firewall
firewall_info

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hrobot/branch/main

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #77 (36920ad) into main (6640769) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          32       32           
  Lines        2302     2302           
  Branches      230      230           
=======================================
  Hits         2263     2263           
  Misses         18       18           
  Partials       21       21           
Flag Coverage Δ
sanity 27.41% <0.00%> (ø)
units 98.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/firewall.py 100.00% <100.00%> (ø)
plugins/modules/firewall_info.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_firewall.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_firewall_info.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein
Copy link
Collaborator Author

@filviu you might also be interested in this PR, though please don't test it before I rebased after merging the other one - otherwise it will remove output rules as well ;-)

Copy link

@maxamillion maxamillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the changes seem reasonable and the code is good. I don't understand the implications to the collection functionality though.

@felixfontein
Copy link
Collaborator Author

Rebased after #76 has been merged.

@felixfontein felixfontein merged commit df7d8da into ansible-collections:main Mar 15, 2023
@felixfontein felixfontein deleted the firewall-id branch March 15, 2023 21:06
@felixfontein
Copy link
Collaborator Author

@maxamillion thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants