Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix boot ssh key setting #33

Merged
merged 10 commits into from
Jan 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 28, 2021

SUMMARY

Fixes #32

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

community.hrobot.boot

ADDITIONAL INFORMATION
  • changes encoding of authorized_key for lists
  • fixes idempotence check for ssh keys

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment?

plugins/modules/boot.py Outdated Show resolved Hide resolved
plugins/modules/boot.py Outdated Show resolved Hide resolved
plugins/modules/boot.py Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Dec 28, 2021

Thanks for your contribution! Can you please add a changelog fragment?

I gave it a try. Is this sufficient?

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #33 (ee51245) into main (5c32ab0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          29       29           
  Lines        1843     1845    +2     
  Branches      159      161    +2     
=======================================
+ Hits         1826     1828    +2     
  Misses          9        9           
  Partials        8        8           
Impacted Files Coverage Δ
tests/unit/plugins/modules/test_boot.py 98.18% <ø> (ø)
plugins/modules/boot.py 97.05% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c32ab0...ee51245. Read the comment docs.

@felixfontein felixfontein merged commit d072c47 into ansible-collections:main Jan 4, 2022
@felixfontein
Copy link
Collaborator

@chaotika thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh-key setting for rescue mode gives errors
2 participants