Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/fix attributes #342

Merged
merged 4 commits into from
Jan 8, 2023

Conversation

briantist
Copy link
Collaborator

SUMMARY

Fixes #325

ISSUE TYPE
  • Docs Pull Request

@briantist briantist added the documentation Improvements or additions to documentation label Jan 8, 2023
@briantist briantist added this to the v4.0.1 milestone Jan 8, 2023
@briantist briantist self-assigned this Jan 8, 2023
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hashi_vault/branch/main

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this, LGTM.

plugins/modules/vault_login.py Outdated Show resolved Hide resolved
plugins/modules/vault_token_create.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #342 (8b2216e) into main (43ed19e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          76       76           
  Lines        3862     3862           
  Branches      250      250           
=======================================
  Hits         3814     3814           
  Misses         39       39           
  Partials        9        9           
Flag Coverage Δ
env_docker-default 98.75% <ø> (ø)
integration 80.93% <ø> (ø)
sanity 39.42% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_azure 53.84% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 83.20% <ø> (ø)
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.42% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 56.28% <ø> (ø)
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.11% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 79.24% <ø> (ø)
target_lookup_vault_write 57.39% <ø> (ø)
target_module_utils 97.36% <ø> (ø)
target_module_vault_kv1_get 87.50% <ø> (ø)
target_module_vault_kv2_delete 56.93% <ø> (ø)
target_module_vault_kv2_get 87.23% <ø> (ø)
target_module_vault_login 83.72% <ø> (ø)
target_module_vault_pki_generate_certificate 78.72% <ø> (ø)
target_module_vault_read 85.71% <ø> (ø)
target_module_vault_token_create 91.66% <ø> (ø)
target_module_vault_write 56.25% <ø> (ø)
target_modules 80.65% <ø> (ø)
units 96.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/attributes.py 100.00% <ø> (ø)
plugins/modules/vault_kv1_get.py 100.00% <ø> (ø)
plugins/modules/vault_kv2_delete.py 100.00% <ø> (ø)
plugins/modules/vault_kv2_get.py 100.00% <ø> (ø)
plugins/modules/vault_login.py 100.00% <ø> (ø)
plugins/modules/vault_pki_generate_certificate.py 95.74% <ø> (ø)
plugins/modules/vault_read.py 100.00% <ø> (ø)
plugins/modules/vault_token_create.py 100.00% <ø> (ø)
plugins/modules/vault_write.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@briantist briantist merged commit 6c93da9 into ansible-collections:main Jan 8, 2023
@briantist briantist deleted the docs/fix-attributes branch January 8, 2023 23:13
@briantist briantist modified the milestones: v4.0.1, v4.1.0 Jan 18, 2023
fh-carlosp pushed a commit to flatironhealth/community.hashi_vault that referenced this pull request May 15, 2023
* fix attributes

* add changelog fragment

* fix changelog secton

* Apply suggestions from code review

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update check_mode attributes to correct description and add details
2 participants