Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace more deprecated assertEquals #406

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

cjwatson
Copy link
Contributor

SUMMARY

TestCase.assertEquals was deprecated and removed in Python 3.12.

Similar to #350, but for code that was added later.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test

@cjwatson cjwatson requested review from rrey and seuf as code owners October 29, 2024 10:41
`TestCase.assertEquals` was deprecated and removed in Python 3.12.

Similar to ansible-collections#350, but for code that was added later.
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.12%. Comparing base (53c9402) to head (a1789ff).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #406       +/-   ##
===========================================
+ Coverage   45.46%   72.12%   +26.66%     
===========================================
  Files          21       21               
  Lines        2228     2228               
  Branches      437      437               
===========================================
+ Hits         1013     1607      +594     
+ Misses       1174      455      -719     
- Partials       41      166      +125     
Flag Coverage Δ
integration 70.87% <ø> (?)
sanity 23.29% <ø> (ø)
units 64.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nemental Nemental merged commit 157b1cb into ansible-collections:main Oct 29, 2024
31 checks passed
@cjwatson cjwatson deleted the more-assertEquals branch October 30, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants