Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support datasource #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Korney95
Copy link

@Korney95 Korney95 commented Jun 29, 2021

add support datasource vertamedia-clickhouse-datasource

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Exaple usage:

- name: Create click datasource
  community.grafana.grafana_datasource:
    name: "click-ansible"
    grafana_url: "{{ grafana_api_url }}"
    grafana_user: "{{ grafana_api_user }}"
    grafana_password: "{{ grafana_api_password }}"
    ds_type: "vertamedia-clickhouse-datasource"
    ds_url: "http://clickhouse:8123"
    basic_auth_user: "clickhouse"
    basic_auth_password: "clickhouse"

add support datasource vertamedia-clickhouse-datasource
@Korney95 Korney95 requested review from rrey and seuf as code owners June 29, 2021 12:48
Copy link
Collaborator

@seuf seuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for submitting this PR.
What is vertamedia clickhouse datasource ? I don"t see it in grafana plugins list.
The appropriate plugin should be installed before adding a new datasource.
Can you add some integration test (install the correct plugin, add the datasource, ensure it exists, remove the datasource, ensure it's deleted) ?

@Korney95
Copy link
Author

Korney95 commented Jul 1, 2021

Привет,
Спасибо за отправку этого PR.
Что такое источник данных Vertamedia Clickhouse? Я не вижу его в списке плагинов Grafana.
Соответствующий плагин должен быть установлен перед добавлением нового источника данных.
Можете добавить какой-нибудь интеграционный тест (установите правильный плагин, добавленный источник данных, убедитесь, что он существует, удалите данные, убедитесь, что он удален)?

Hi, here is the plugin link. Launch via ansible adding / changing data source clickhouse no problems were noticed

@gutsul
Copy link

gutsul commented Jan 18, 2022

@seuf Do you plan to add this feature to the main branch?

@seuf
Copy link
Collaborator

seuf commented Jan 18, 2022

This PR need to add more integration tests. See example here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants