Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purestorage: deprecate leftovers #9432

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 27, 2024

SUMMARY

Modules supporting purestorage were removed from the collection in version 3.0.0 but the module utils and a doc fragment were left behind. This PR deprecates them.

(Additionally, this PR fixes the ordering for the old rackspace removal in those two sections of runtime.yml)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/doc_fragments/purestorage.py
plugins/module_utils/pure.py

@ansibullbot ansibullbot added the feature This issue/PR relates to a feature request label Dec 27, 2024
changelogs/fragments/9432-deprecate-pure.yml Outdated Show resolved Hide resolved
changelogs/fragments/9432-deprecate-pure.yml Outdated Show resolved Hide resolved
meta/runtime.yml Outdated Show resolved Hide resolved
meta/runtime.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 27, 2024
@ansibullbot

This comment was marked as resolved.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 27, 2024
@russoz
Copy link
Collaborator Author

russoz commented Dec 27, 2024

Actually, the other PR just removed the doc fragment, so this one should be only abou the mod util

@felixfontein
Copy link
Collaborator

The doc fragment is still there, it has not been removed in the other PR.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 27, 2024
@russoz russoz force-pushed the deprecate-pure-leftover branch from 6a370de to 930a61f Compare December 28, 2024 02:16
@felixfontein felixfontein merged commit bde58a7 into ansible-collections:main Dec 28, 2024
129 checks passed
Copy link

patchback bot commented Dec 28, 2024

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/bde58a7b429f7bfe996be98317e9d16ec8956db8/pr-9432

Backported as #9440

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 28, 2024
@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Dec 28, 2024
* purestorage: deprecate leftovers

* add changelog frag

* fixes

(cherry picked from commit bde58a7)
felixfontein pushed a commit that referenced this pull request Dec 28, 2024
…ers (#9440)

purestorage: deprecate leftovers (#9432)

* purestorage: deprecate leftovers

* add changelog frag

* fixes

(cherry picked from commit bde58a7)

Co-authored-by: Alexei Znamensky <[email protected]>
@russoz russoz deleted the deprecate-pure-leftover branch December 28, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch feature This issue/PR relates to a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants