Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module ldap inc #9275

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pduveau
Copy link

@pduveau pduveau commented Dec 17, 2024

SUMMARY

This contribution propose to adds a module that use the ‘modify-increment’ capability corresponding to the extension implemented by OpenLdap described in RFC-4525. It can be used to increment an integer attribute and read it atomically. It is an help for managing posix userId while relying only on the directory server.

ISSUE TYPE

Not an issue

COMPONENT NAME

ldap_inc

ADDITIONAL INFORMATION

The module uses the DN of the entry containing the "sequence", the attribute to increment and the increment to apply. The result of the module is the new value of "sequence".

This module adds the ‘modify-increment’ capability corresponding to the extension implemented by OpenLdap described in RFC-4525. It can be used to increment an integer attribute and read it atomically. It is an help for posix userId definition while relying only on the directory server.
@ansibullbot

This comment was marked as duplicate.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) labels Dec 17, 2024
@pduveau pduveau closed this Dec 17, 2024
@pduveau
Copy link
Author

pduveau commented Dec 17, 2024

After fixing quality check errors and warnings

@pduveau pduveau reopened this Dec 17, 2024
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 18, 2024
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pduveau thanks for your contribution!

Got a couple of comments below, but overall it looks good.

plugins/modules/ldap_inc.py Show resolved Hide resolved
plugins/modules/ldap_inc.py Outdated Show resolved Hide resolved
plugins/modules/ldap_inc.py Show resolved Hide resolved
Fully aligned with that

Co-authored-by: Alexei Znamensky <[email protected]>
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 20, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please note that all new modules must have tests (unit and/or integration tests). See the ldap_search integration tests in tests/integration/targets/ldap_search/ as an example.

plugins/modules/ldap_inc.py Outdated Show resolved Hide resolved
plugins/modules/ldap_inc.py Show resolved Hide resolved
@ansibullbot
Copy link
Collaborator

The test botmeta failed with an unknown error. Please check out the CI logs.


click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. ci_verified Push fixes to PR branch to re-run CI module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants