Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycloak_authentication: Fix priority attribute during execution updates #9263

Merged
merged 1 commit into from
Dec 20, 2024
Merged

keycloak_authentication: Fix priority attribute during execution updates #9263

merged 1 commit into from
Dec 20, 2024
+9 −4

Conversation

apollo13
Copy link
Contributor

SUMMARY

The module doesn't pass the required priority attribute back to the server during updates resulting in broken authentication flows

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_authentication

ADDITIONAL INFORMATION

@apollo13 apollo13 force-pushed the fb-keycloak-auth-priority branch from 5db1168 to c242068 Compare December 16, 2024 19:00
@ansibullbot
Copy link
Collaborator

cc @Gaetan2907 @eikef @elfelip @mattock @ndclt @thomasbach-dev
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug identity module module module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) labels Dec 16, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Dec 16, 2024
felixfontein
felixfontein reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/9263-kc_authentication-api-priority.yaml Outdated Show resolved Hide resolved
plugins/module_utils/identity/keycloak/keycloak.py Outdated Show resolved Hide resolved
plugins/modules/keycloak_authentication.py Outdated Show resolved Hide resolved
@apollo13 apollo13 force-pushed the fb-keycloak-auth-priority branch from c242068 to f9bd658 Compare December 16, 2024 20:10
@ansibullbot ansibullbot added tests tests unit tests/unit and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 16, 2024
russoz
russoz approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apollo13
Copy link
Contributor Author

Internal testing showed an issue with subflows, will update in a few minutes.

@apollo13 apollo13 force-pushed the fb-keycloak-auth-priority branch from f9bd658 to 143a1a9 Compare December 17, 2024 11:05
@apollo13 apollo13 force-pushed the fb-keycloak-auth-priority branch from 143a1a9 to 4262902 Compare December 17, 2024 11:12
@apollo13
Copy link
Contributor Author

Reduced to the minimal fix. Internal testing was successful. From our side this is mergeable.

@felixfontein
Copy link
Collaborator

Looks good to me as well. If nobody objects, I'll merge by the end of the week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 20, 2024
@felixfontein felixfontein merged commit 2682ec4 into ansible-collections:main Dec 20, 2024
129 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 20, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/2682ec47d9edf21a1ea4ed99a81c00cf857e636a/pr-9263

Backported as #9290

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 20, 2024
@apollo13 @patchback
keycloak_authentication: Fix priority attribute during execution upda…
47e3b64 
…tes (#9263)

keycloak_authentication: Fix priority attribute during execution updates.

(cherry picked from commit 2682ec4)
@patchback Patchback
Copy link

patchback bot commented Dec 20, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/2682ec47d9edf21a1ea4ed99a81c00cf857e636a/pr-9263

Backported as #9291

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Dec 20, 2024
Merged
@felixfontein
Copy link
Collaborator

@apollo13 thanks for reporting and fixing this!
@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Dec 20, 2024
@apollo13 @patchback
keycloak_authentication: Fix priority attribute during execution upda…
aca53ac 
…tes (#9263)

keycloak_authentication: Fix priority attribute during execution updates.

(cherry picked from commit 2682ec4)
@patchback Patchback
Copy link

patchback bot commented Dec 20, 2024 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/2682ec47d9edf21a1ea4ed99a81c00cf857e636a/pr-9263

Backported as #9292

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Dec 20, 2024
Merged
patchback bot pushed a commit that referenced this pull request Dec 20, 2024
@apollo13 @patchback
keycloak_authentication: Fix priority attribute during execution upda…
51dcb9f 
…tes (#9263)

keycloak_authentication: Fix priority attribute during execution updates.

(cherry picked from commit 2682ec4)
@patchback patchback bot mentioned this pull request Dec 20, 2024
Merged
felixfontein pushed a commit that referenced this pull request Dec 20, 2024
@patchback @apollo13
[PR #9263/2682ec47 backport][stable-8] keycloak_authentication: Fix p…
6d39378 
…riority attribute during execution updates (#9290)

keycloak_authentication: Fix priority attribute during execution updates (#9263)

keycloak_authentication: Fix priority attribute during execution updates.

(cherry picked from commit 2682ec4)

Co-authored-by: Florian Apolloner <[email protected]>
felixfontein pushed a commit that referenced this pull request Dec 20, 2024
@patchback @apollo13
[PR #9263/2682ec47 backport][stable-9] keycloak_authentication: Fix p…
aa3a43c 
…riority attribute during execution updates (#9291)

keycloak_authentication: Fix priority attribute during execution updates (#9263)

keycloak_authentication: Fix priority attribute during execution updates.

(cherry picked from commit 2682ec4)

Co-authored-by: Florian Apolloner <[email protected]>
felixfontein pushed a commit that referenced this pull request Dec 20, 2024
@patchback @apollo13
[PR #9263/2682ec47 backport][stable-10] keycloak_authentication: Fix …
5ab43f0 
…priority attribute during execution updates (#9292)

keycloak_authentication: Fix priority attribute during execution updates (#9263)

keycloak_authentication: Fix priority attribute during execution updates.

(cherry picked from commit 2682ec4)

Co-authored-by: Florian Apolloner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug identity module_utils module_utils module module plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apollo13 @ansibullbot @felixfontein @russoz