Add inventory plugin iocage #9262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
the
needs_revision
ansibullbot
removed
the
needs_revision
felixfontein
added
check-before-release
russoz
reviewed
Dec 17, 2024
russoz
reviewed
Dec 17, 2024
| def test_verify_file(tmp_path, inventory): | ||
| file = tmp_path / "foobar.iocage.yml" | ||
| file.touch() | ||
| assert inventory.verify_file(str(file)) is True |
There was a problem hiding this comment.
It would be nice to have more extensive tests, than this absolutely bare minimum :)
There was a problem hiding this comment.
I completed the tests.
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
* Create get_jails and get_properties in iocage plugin to simplify testing. * Update test_iocage.py * Add fixtures iocage_*
russoz
reviewed
Dec 20, 2024
plugins/inventory/iocage.py
Outdated
Comment on lines
20
to
22
| - By default, O(host) is V(localhost). If O(host) is not V(localhost) it | ||
| is expected that the O(user) is able to connect to the O(host) with | ||
| SSH and execute the command C(iocage list). |
There was a problem hiding this comment.
Technically, it is not the O(user) (remote user on the target iocage host) that must be able to connect. This would be more accurate as:
"... expected that the user running Ansible on the controller is able to connect with SSH to the O(host) with O(user) without specifying password or key, and O(user) is able to execute the command C(iocage list)."
Or something along those lines - feel free to wordsmith it to your satisfaction.
There was a problem hiding this comment.
Thank you. I updated the description item
- By default, O(host) is V(localhost). If O(host) is not V(localhost) it
is expected that the user running Ansible on the controller can
connect to the O(host) account O(user) with SSH non-interactively and
execute the command C(iocage list).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implement Add inventory plugin iocage #9261
Feature Pull Request
iocage
Tested in: