[PR #7485/68051774 backport][stable-8] [proxmox_vm_info] Add ability to retrieve config #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* feat: add ability to retrieve config Light refactor of get_vms_from_nodes function. Added ability to retrieve configuration for existing machines (current or pending). * Add changelog fragment * Add changelog fragment (newline missed) * Update changelogs/fragments/7485-proxmox_vm_info-config.yml Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Replaced two bool options with one three-state option * Module args for the three-state option * Remove trailing newline * Make use of dict instead of list. Fix uncalled 'get config for lxc'. * Sanity tests * A couple of unit tests fixed * Unit tests fixed * Unit tests for p2.7 fixed. Test for config parameter added. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 6805177)
ansibullbot
added
backport
feature
felixfontein
deleted the
patchback/backports/stable-8/68051774d8ce602273e7ee3ab41760d3c0a6d158/pr-7485
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7485 as merged into main (6805177).
SUMMARY
Added ability to retrieve configuration for existing machines (current or pending). (I am trying to bootstrap Ignition cloud images and configuration info will help to configure network interfaces based on their MAC-addresses which are randomly generated on VM creation).
Light refactor of
get_vms_from_nodesfunction (informative variable names).ISSUE TYPE
COMPONENT NAME
proxmox_vm_info
ADDITIONAL INFORMATION