Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvol: Change pvs argument type to list (of str) #7676

Merged
merged 3 commits into from
Dec 4, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply review suggestions
lszomor committed Dec 3, 2023
commit bcfe8b353b776982028368596eef1aee5f368150
2 changes: 1 addition & 1 deletion changelogs/fragments/7676-lvol-pvs-as-list.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
minor_changes:
- lvol - Change ``pvs`` argument type to list (of str). (https://github.com/ansible-collections/community.general/pull/7676, https://github.com/ansible-collections/community.general/issues/7504).
- lvol - change ``pvs`` argument type to list of strings (https://github.com/ansible-collections/community.general/pull/7676, https://github.com/ansible-collections/community.general/issues/7504).
6 changes: 4 additions & 2 deletions plugins/modules/lvol.py
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@
type: list
elements: str
description:
- List of physical volumes (e.g. /dev/sda,/dev/sdb).
- List of physical volumes (for example V(/dev/sda, /dev/sdb)).
thinpool:
type: str
description:
@@ -111,7 +111,9 @@
vg: firefly
lv: test
size: 512
pvs: /dev/sda,/dev/sdb
pvs:
- /dev/sda
- /dev/sdb

- name: Create cache pool logical volume
community.general.lvol: