Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat nomad token module #7523

Merged

Conversation

apecnascimento
Copy link
Contributor

SUMMARY

Add ability to manage acl tokens in nomad:

  • Create tokens
  • Update tokens
  • Delete tokens

Implements: #7522

ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

nomad_token

@ansibullbot

This comment was marked as outdated.

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) labels Nov 15, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Nov 15, 2023
@ansibullbot

This comment was marked as outdated.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Nov 15, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 15, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Nov 15, 2023
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI labels Nov 15, 2023
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 15, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 28, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 28, 2023
Co-authored-by: Felix Fontein <[email protected]>
@felixfontein
Copy link
Collaborator

There are still two unresolved comments, that GitHub has been unfortunately hiding. You can see them in the "Files changed" view, or when going through all the unhide buttons.

@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 1, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one last thing.

plugins/modules/nomad_token.py Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 88d2a3a into ansible-collections:main Dec 3, 2023
125 checks passed
Copy link

patchback bot commented Dec 3, 2023

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/88d2a3a1fbf9e8a2bf7f5d4dd3631ea1843bf015/pr-7523

Backported as #7677

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 3, 2023
patchback bot pushed a commit that referenced this pull request Dec 3, 2023
* Add nomad_token module

* Updatate nomad maintainers list

* Fix Example docstring

* Fix identations and Flake8 rules

* Fix  trailing whitespace

* Fix SyntaxError error

* change stringh format

* Fix Return doc string

* Fix Examples

* Fix flake8  rule W293

* Fix Doc schema

* Fix argument_spec

* Add maintainer

* Fix Example doc

* Remove token_info

* Change Doc

* Change nomad api acl token link

* Remove return whitespace

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Fix add changed state to True

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Change suport check mode

* Add unity tests

* Remove unused import

* Remove tests unused import

* Change python-nomad versions

Co-authored-by: Felix Fontein <[email protected]>

* Change acl for ACL

Co-authored-by: Felix Fontein <[email protected]>

* Add ACL to all docs

* Change msg to ansible common return value

* Fix flake8 W291

* Update description.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 88d2a3a)
@felixfontein
Copy link
Collaborator

@apecnascimento thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Dec 3, 2023
Feat nomad token module (#7523)

* Add nomad_token module

* Updatate nomad maintainers list

* Fix Example docstring

* Fix identations and Flake8 rules

* Fix  trailing whitespace

* Fix SyntaxError error

* change stringh format

* Fix Return doc string

* Fix Examples

* Fix flake8  rule W293

* Fix Doc schema

* Fix argument_spec

* Add maintainer

* Fix Example doc

* Remove token_info

* Change Doc

* Change nomad api acl token link

* Remove return whitespace

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Fix add changed state to True

* Update plugins/modules/nomad_token.py

Co-authored-by: Felix Fontein <[email protected]>

* Change suport check mode

* Add unity tests

* Remove unused import

* Remove tests unused import

* Change python-nomad versions

Co-authored-by: Felix Fontein <[email protected]>

* Change acl for ACL

Co-authored-by: Felix Fontein <[email protected]>

* Add ACL to all docs

* Change msg to ansible common return value

* Fix flake8 W291

* Update description.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 88d2a3a)

Co-authored-by: apecnascimento <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch merge_commit This PR contains at least one merge commit. Please resolve! module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_plugin New plugin plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants