[PR #7468/65f58afb backport][stable-8] Improve performance of the bitwarden lookup plugin #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Improve performance of the bitwarden lookup plugin When looking for items using an item id, we can access the item directly with bw get item instead of searching through all items. This doubles the lookup speed. * Update changelogs/fragments/bitwarden-lookup-performance.yaml Co-authored-by: Felix Fontein <[email protected]> * fix indentation * Ensure backwards compatible behavior in case of errors when doing bitwarden lookup by id * chore: Link to correct PR in changelog fragment * Use identity check when comparing with None --------- Co-authored-by: Richard Klose <[email protected]> Co-authored-by: Richard Klose <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 65f58af)
ansibullbot
added
backport
lookup
|
Marking as draft so this won't get merged until the last 8.0.x bugfix release is out. |
felixfontein
deleted the
patchback/backports/stable-8/65f58afbd9f559dbab50e251e6e8f7184e76d0ee/pr-7468
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7468 as merged into main (65f58af).
SUMMARY
The bitwarden lookup plugin searches through all items using
bw list items --search, which takes a lot of time. However, when looking for an item using the item id, there is a much faster way:bw get item <itemid>. This PR introduces this method for every lookup that uses the item's id, while keeping backwards compatibility.This work is based on #6619. The open review comment there has been addressed.
ISSUE TYPE
COMPONENT NAME
bitwarden
ADDITIONAL INFORMATION
None