Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7456/c2f08c57 backport][stable-8] [ssh_config] Add support for ControlMaster #7510

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 11, 2023

This is a backport of PR #7456 as merged into main (c2f08c5).

SUMMARY

Add support for ControlMaster (with ControlPath, ControlPersist) SSH config options.

Second commit also converts bool to str correctly for options which allow yes / no in addition to other values as YAML yes / no is parsed as True / False but ssh_config needs "yes" / "no".

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ssh_config

ADDITIONAL INFORMATION

None

* [ssh_config] Add support for ControlMaster

* Create separate function to convert bool

* Allow str values with yes/no options to also use bool

(cherry picked from commit c2f08c5)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Nov 11, 2023
@felixfontein felixfontein marked this pull request as draft November 11, 2023 11:14
@ansibullbot ansibullbot added the WIP Work in progress label Nov 11, 2023
@felixfontein
Copy link
Collaborator

Marking as draft so this won't get merged until the last 8.0.x bugfix release is out.

@felixfontein felixfontein marked this pull request as ready for review November 13, 2023 19:21
@felixfontein felixfontein merged commit 20d2488 into stable-8 Nov 13, 2023
118 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/c2f08c57e0d3ec49867baadcaf5ab2e3811ba13f/pr-7456 branch November 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants