infiniband and bond interfaces can receive MTU settings too

[mark-tomich]

SUMMARY

Infiniband and bond interface types can also receive MTU settings

Changelog:
Enabling setting of MTU on bond and Infiniband interfaces

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

nmcli

ADDITIONAL INFORMATION

I think this is pretty straight-forward... I don't know what else to add.

[ansibullbot]

cc @alcamie101
click here for bot help

[felixfontein]

Thanks for your contribution! Please check the unit tests, they now fail; you can find them in tests/unit/plugins/modules/test_nmcli.py. Also please add a changelog fragment.

[mark-tomich]

@felixfontein I think this is now ready to go...thanks for the pointers.

[felixfontein]

If nobody objects, I'll merge this in ~a week.

[patchback]

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/d0870a022e7e8b688fb44db403e0c65db214953a/pr-7499

Backported as #7527

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@mark-tomich thanks for your contribution!

[psvmcc]

Hi, @mark-tomich @felixfontein

I have issue after updating from 7.3.0 to 8.4.0:

Diff on nmcli changes in this PR:

--- before
+++ after
@@ -1,5 +1,5 @@
 {
-    "802-3-ethernet.mtu": null,
+    "802-3-ethernet.mtu": "auto",
     "connection.autoconnect": "yes",
     "connection.interface-name": "bond0",
     "downdelay": "200",
changed: [server1] => (item=bond0)

I have handler with command like:

        cmd: 'nmcli device reapply {{ item }}'

And I got this error, with exit code 6:

Error: Reapplying connection to device 'bond0' (/org/freedesktop/NetworkManager/Devices/2) failed: Can't reapply changes to '802-3-ethernet.port' setting

nmcli tool, version 1.44.0-3.0.1.el9

Before this patch with nmcli conn show bond0 I can't see any settings for 802-3-ethernet key, but after patching I see them like:

802-3-ethernet.port:                    --
802-3-ethernet.speed:                   0
802-3-ethernet.duplex:                  --
802-3-ethernet.auto-negotiate:          no
802-3-ethernet.mac-address:             --
802-3-ethernet.cloned-mac-address:      --
802-3-ethernet.generate-mac-address-mask:--
802-3-ethernet.mac-address-blacklist:   --
802-3-ethernet.mtu:                     auto
802-3-ethernet.s390-subchannels:        --
802-3-ethernet.s390-nettype:            --
802-3-ethernet.s390-options:            --
802-3-ethernet.wake-on-lan:             default
802-3-ethernet.wake-on-lan-password:    --
802-3-ethernet.accept-all-mac-addresses:-1 (default)

I think setting MTU should be on bond slaves, not on bond interface, so setting MTU on bond interface should be removed from module.

What you think?

UPD: well actually after reboot I don't have this issues, but this is terrible.

UPD2: ok, never mind, seems its only my case, so I will solve it from my side.

[mark-tomich]

I'm sorry you're having trouble, but it's definitely valid to set / reset the MTU on a bond interface:

[root@hostname ~]# ip l show bond1
13: bond1: <NO-CARRIER,BROADCAST,MULTICAST,MASTER,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
    link/ether e6:a4:af:ca:e8:49 brd ff:ff:ff:ff:ff:ff
[root@hostname ~]# nmcli c modify bond1 +802-3-ethernet.mtu 1499
[root@hostname ~]# nmcli d reapply bond1
Connection successfully reapplied to device 'bond1'.
[root@hostname ~]# ip l show bond1
13: bond1: <NO-CARRIER,BROADCAST,MULTICAST,MASTER,UP> mtu 1499 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
    link/ether e6:a4:af:ca:e8:49 brd ff:ff:ff:ff:ff:ff

[psvmcc]

Yes, valid, I will fix it himself, thanks and sorry!)

[psvmcc]

Hi, @mark-tomich I need your help :)

When I creating bond interface with nmcli module, and not setting mtu, its should be in auto mode, but if I run task again it not idempotence, and showed me changes

--- before
+++ after
@@ -1,5 +1,5 @@
 {
-    "802-3-ethernet.mtu": null,
+    "802-3-ethernet.mtu": "auto",
     "connection.autoconnect": "yes",
     "connection.interface-name": "bond1",
     "downdelay": "200",

changed: [host1] => (item=bond1)

Its because I can't see in nmcli s sh bond1 | grep ether any options. Hotfix for that is set it like:

nmcli c mod bond1 802-3-ethernet.mtu auto
systemctl restart NetworkManager

After this I can't see any changes in playbook.

One solution is set mtu for each connections to 1500(default), then everything works fine. But I'm not sure its good way. Maybe better add skip to nmcli module if current value is null, then it equal to auto?

Or maybe some other ideas?

Thanks!