Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6813/55893f27 backport][stable-7] Adding CreateVolume functionality #7359

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 6, 2023

This is a backport of PR #6813 as merged into main (55893f2).

SUMMARY
Adding functionality to create volumes on Gen11 servers.

ISSUE TYPE

  • Feature Pull Request

COMPONENT NAME
redfish_config.py
redfish_utils.py

* Adding create volume functionality

* Adding changelog fragment

* Sanity Fix

* Sanity fix

* Update 6813-redfish-config-add-create-volume.yml

* Sanity fix

* Sanity fix

* Removing capabilities check and correcting controllers terminology to storage subsystem

* Updating as per PR suggestions

* sanity fix

* Update plugins/modules/redfish_config.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/redfish_config.py

Agreed

Co-authored-by: Felix Fontein <[email protected]>

* Fixing merge issue

* Fixing sanity issues

* Adding CapacityBytes as a mandatory parameter and adding failure message when run for server below iLO6

* Sanity fix

* Sanity fix

* Updating vendor specific failure

* Update plugins/modules/redfish_config.py

Agreed

Co-authored-by: Felix Fontein <[email protected]>

* Removing vendor specific failure case

* removing unused import

---------

Co-authored-by: Kushal <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 55893f2)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 6, 2023
@felixfontein felixfontein merged commit 8385d2e into stable-7 Oct 6, 2023
141 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-7/55893f27c99282028069728e2b1e2f44478c0455/pr-6813 branch October 6, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants