[PR #7339/39895a6d backport][stable-7] pnpm: version should not be latest when state is latest #7347
+23
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ansibullbot
added
backport
bug
ansibullbot
removed
the
needs_revision
* (fix) don't set version at latest at state: latest If version is forcefully set at latest when state is latest, the package will always be changed, as there is no version "latest" will ever be detected. It is better to keep it None. * (fix) fixed tests to reflect recent changes * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * (feat) added changelog fragment for pull #7339 * (fix) apply correct punctuation to changelog Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 39895a6)
felixfontein
force-pushed
the
patchback/backports/stable-7/39895a6d38220d3a8ff959c6770acff956fbbcfd/pr-7339
branch
from
e6b87f5 to
6418285
Compare
felixfontein
deleted the
patchback/backports/stable-7/39895a6d38220d3a8ff959c6770acff956fbbcfd/pr-7339
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7339 as merged into main (39895a6).
If version is forcefully set at latest when state is latest, the package will always be changed, as there is no version "latest" will ever be detected. It is better to keep it None.
SUMMARY
Fixes the idempotency problem when state is latest, Previously, version was set at latest when state was latest, so the package was updated every time. This should be fixed now.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION