Add support for Oem params #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
module
|
Code looks good to me; thanks! |
1 task
felixfontein
added
check-before-release
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
Add version_added field
it should not be in the payload if not defined
|
@mraineri if you're still happy I'll merge this at the beginning of the upcoming week. |
|
Yup, the changes look good to me |
felixfontein
added
backport-7
and removed
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7341 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Add support for "Oem" parameters in the MultipartHTTPPushUpdate redfish_command * Add doc entry * Add changelog fragment Add version_added field * Re-word the changelog fragment * After further testing this should not have a default definition as it should not be in the payload if not defined (cherry picked from commit cd83b24)
felixfontein
pushed a commit
that referenced
this pull request
Oct 2, 2023
) Add support for Oem params (#7330) * Add support for "Oem" parameters in the MultipartHTTPPushUpdate redfish_command * Add doc entry * Add changelog fragment Add version_added field * Re-word the changelog fragment * After further testing this should not have a default definition as it should not be in the payload if not defined (cherry picked from commit cd83b24) Co-authored-by: Scott Seekamp <[email protected]>
etrombly
pushed a commit
to etrombly/community.general
that referenced
this pull request
Oct 25, 2023
* Add support for "Oem" parameters in the MultipartHTTPPushUpdate redfish_command * Add doc entry * Add changelog fragment Add version_added field * Re-word the changelog fragment * After further testing this should not have a default definition as it should not be in the payload if not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible resolution to #7331
Add support for Oem parameters in the MultipartHTTPPushUpdate command of
redfish_command