[PR #7242/c3fd14e1 backport][stable-7] Ignore similar chars in random_string #7292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Added the option to ignore certain characters This can be usefull for eliminating confusion. * Removed the loop and added each char_sets The variable name is not known inside the loop so updating it does not work. * Changelog fragment file * Forgot the file extention for the fragment yaml file * Update plugins/lookup/random_string.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/lookup/random_string.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/lookup/random_string.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit c3fd14e)
ansibullbot
added
backport
feature
felixfontein
deleted the
patchback/backports/stable-7/c3fd14e18f7ced21df42abc4e9f310f070ad7a55/pr-7242
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7242 as merged into main (c3fd14e).
SUMMARY
Added the option to ignore certain characters.
With the current parameters it is not possible to avoid similar character while also improve readability for passwords. If the parameter “override_all” is used the parameters “min_lower”, “min_upper”, “min_numeric” and “min_special” are ignored. This makes it hard to both achieve readability for passwords and adhere to configured password policies.
ISSUE TYPE
COMPONENT NAME
plugins/lookup/random_string.py
ADDITIONAL INFORMATION