ldap_search: make sure to also handle binary strings in Python 3 #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ursetto would be glad if you could try this out. |
felixfontein
added
the
check-before-release
ansibullbot
added
bug
|
@felixfontein This seems to have fixed it. Tested with # Encodes everything (except "dn")
- base64_attributes:
- '*'# Encodes just these two binary fields, which is enough to avoid a crash
- base64_attributes:
- objectGUID
- objectSidAnd finally without So everything seems to be working as expected. |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7268 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Make sure to also handle binary strings in Python 3. (cherry picked from commit fc530cd)
|
@ursetto thanks a lot for reporting this and for testing! |
felixfontein
added a commit
that referenced
this pull request
Sep 15, 2023
… handle binary strings in Python 3 (#7268) ldap_search: make sure to also handle binary strings in Python 3 (#7264) Make sure to also handle binary strings in Python 3. (cherry picked from commit fc530cd) Co-authored-by: Felix Fontein <[email protected]>
felixfontein
removed
the
check-before-release
etrombly
pushed a commit
to etrombly/community.general
that referenced
this pull request
Oct 25, 2023
…ible-collections#7264) Make sure to also handle binary strings in Python 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #5704
Fixes #7262
Updates #6475
ISSUE TYPE
COMPONENT NAME
ldap_search