Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6546/c76af60a backport][stable-7] ini_file: Don't creates new file instead of following symlink #6598

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 29, 2023

This is a backport of PR #6546 as merged into main (c76af60).

SUMMARY

This is a bug fix that address a situation where community.general.ini_file was destroying symlinks instead of updating of updating their targets.

If poth points on a symlink and follow is true, the ini_file plugin will preserve the symlink and modify the target file.

Closes: #6470

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ini_file

* ini_file: Don't creates new file instead of following symlink

This is a bug fix that address a situation where `community.general.ini_file`
was destroying symlinks instead of updating of updating their targets.

Closes: #6470

* ini_file: add the follow parameter

If `poth` points on a symlink and `follow` is true, the `ini_file` plugin
will preserve the symlink and modify the target file.

* adjust the documentation of the new key

- yes/no -> true/false.
- new key will be introduced in 7.1.0.
- clean up the `state=link` part.

(cherry picked from commit c76af60)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 29, 2023
@felixfontein felixfontein merged commit c4ebd48 into stable-7 May 29, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/c76af60a73c9c058524313cf912a0e08e8427975/pr-6546 branch May 29, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants