Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add append option to ipa_hostgroup module #6203

Merged
merged 7 commits into from
Apr 22, 2023
Merged

Add append option to ipa_hostgroup module #6203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
214039a
Add append option to ipa_hostgroup module
Aug 4, 2022
3408b64
Update plugins/modules/ipa_hostgroup.py
jansobczak Apr 6, 2023
852b150
Update plugins/modules/ipa_hostgroup.py
jansobczak Apr 20, 2023
f3cd800
Add changelog fragment
Apr 20, 2023
b505982
Move choices argument to previous line
Apr 20, 2023
5152d00
Update plugins/modules/ipa_hostgroup.py
jansobczak Apr 20, 2023
a783acd
Update changelogs/fragments/6203-add-append-option-to-ipa-hostgroup.yml
jansobczak Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/6203-add-append-option-to-ipa-hostgroup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- ipa_hostgroup - add ``append`` parameter for adding a new hosts to existing hostgroups without changing existing hostgroup members (https://github.com/ansible-collections/community.general/pull/6203).
21 changes: 17 additions & 4 deletions plugins/modules/ipa_hostgroup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
diff_mode:
support: none
options:
append:
description:
- If C(true), add the listed I(host) to the I(hostgroup).
- If C(false), only the listed I(host) will be in I(hostgroup), removing any other hosts.
default: false
type: bool
jansobczak marked this conversation as resolved.
Show resolved Hide resolved
version_added: 6.6.0
cn:
description:
- Name of host-group.
Expand Down Expand Up @@ -147,6 +154,7 @@ def ensure(module, client):
state = module.params['state']
host = module.params['host']
hostgroup = module.params['hostgroup']
append = module.params['append']

ipa_hostgroup = client.hostgroup_find(name=name)
module_hostgroup = get_hostgroup_dict(description=module.params['description'])
Expand All @@ -168,14 +176,18 @@ def ensure(module, client):
client.hostgroup_mod(name=name, item=data)

if host is not None:
changed = client.modify_if_diff(name, ipa_hostgroup.get('member_host', []), [item.lower() for item in host],
client.hostgroup_add_host, client.hostgroup_remove_host) or changed
changed = client.modify_if_diff(name, ipa_hostgroup.get('member_host', []),
[item.lower() for item in host],
client.hostgroup_add_host,
client.hostgroup_remove_host,
append=append) or changed

if hostgroup is not None:
changed = client.modify_if_diff(name, ipa_hostgroup.get('member_hostgroup', []),
[item.lower() for item in hostgroup],
client.hostgroup_add_hostgroup,
client.hostgroup_remove_hostgroup) or changed
client.hostgroup_remove_hostgroup,
append=append) or changed

else:
if ipa_hostgroup:
Expand All @@ -192,7 +204,8 @@ def main():
description=dict(type='str'),
host=dict(type='list', elements='str'),
hostgroup=dict(type='list', elements='str'),
state=dict(type='str', default='present', choices=['present', 'absent', 'enabled', 'disabled']))
state=dict(type='str', default='present', choices=['present', 'absent', 'enabled', 'disabled']),
append=dict(type='bool', default=False))

module = AnsibleModule(argument_spec=argument_spec,
supports_check_mode=True)
Expand Down