Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini_file: fix lint error #5307

Merged
merged 3 commits into from
Sep 25, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Sep 25, 2022

SUMMARY

Fixed lint error that was being ignored

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/files/ini_file.py

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug files module module plugins plugin (any type) labels Sep 25, 2022
@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test pylint [explain] failed with 1 error:

tests/sanity/ignore-2.12.txt:20:1: ansible-test: Ignoring 'bad-option-value' on 'plugins/modules/files/ini_file.py' is unnecessary

The test ansible-test sanity --test pylint [explain] failed with 1 error:

tests/sanity/ignore-2.11.txt:25:1: ansible-test: Ignoring 'bad-option-value' on 'plugins/modules/files/ini_file.py' is unnecessary

The test ansible-test sanity --test pylint [explain] failed with 1 error:

tests/sanity/ignore-2.13.txt:20:1: ansible-test: Ignoring 'bad-option-value' on 'plugins/modules/files/ini_file.py' is unnecessary

click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 25, 2022
@ansibullbot ansibullbot added tests tests and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 25, 2022
@felixfontein felixfontein merged commit f0ee21b into ansible-collections:main Sep 25, 2022
@patchback
Copy link

patchback bot commented Sep 25, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/f0ee21b8b2fa3b4ca97db7b243750ae55251db1d/pr-5307

Backported as #5308

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

Thanks for fixing this!

patchback bot pushed a commit that referenced this pull request Sep 25, 2022
* ini_file: fix lint error

* add changelog fragment

* remove line from sanity test ignore files

(cherry picked from commit f0ee21b)
felixfontein pushed a commit that referenced this pull request Sep 25, 2022
* ini_file: fix lint error

* add changelog fragment

* remove line from sanity test ignore files

(cherry picked from commit f0ee21b)

Co-authored-by: Alexei Znamensky <[email protected]>
@russoz russoz deleted the ini_file-lint branch September 25, 2022 19:50
v1v added a commit to v1v/community.general that referenced this pull request Oct 7, 2022
* upstream/main: (203 commits)
  Make pfexec become usable for illumos (ansible-collections#3889)
  znode: add options for authentication (ansible-collections#5306)
  keycloak_user_federation: add explanation and example to vendor option (ansible-collections#4893)
  Next expected release is 5.8.0.
  Allow terraform module to specify complex variable structures (ansible-collections#4797)
  Fix ansible-collections#5313: redhat_subscription module is not idempotent when pool_ids (ansible-collections#5319)
  bitwarden: Add field to search for all item attributes, instead of on… (ansible-collections#5297)
  New Module: Keycloak User Rolemapping (ansible-collections#4898)
  chore: Update lxc_container to support py3 (ansible-collections#5304)
  terraform: run `init` with no-color, too (ansible-collections#5147)
  nmcli: fix error when setting previously unset mac address (ansible-collections#5291)
  [feat] proxmox_snap: snapshot containers with configured mountpoints (ansible-collections#5274)
  machinectl: include the success command (ansible-collections#5287)
  Add SetSessionService to redfish_config (ansible-collections#5009)
  locale_gen: fix UbuntuMode (ansible-collections#5282)
  ini_file: fix lint error (ansible-collections#5307)
  netcup_dnsapi: Add timeout paramter (ansible-collections#5301)
  stable-2.14 is now default.
  Add stable-2.14 to CI, adjust to devel version bump (ansible-collections#5298)
  Try to run reuse workflow without explicitly allowing it for new contributors. (ansible-collections#5296)
  ...
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
* ini_file: fix lint error

* add changelog fragment

* remove line from sanity test ignore files
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
* ini_file: fix lint error

* add changelog fragment

* remove line from sanity test ignore files
This was referenced Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug files module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants