[PR #4334/53f6c680 backport][stable-4] nmcli: Change hairpin default mode #4558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* nmcli: Deprecate default hairpin mode Deprecate the default hairpin mode for a bridge. Plain nmcli/bridge tools defaults to no, but for some reason ansible defaults to yes. We deprecate the default value so we can switch to default 'no' in ansible 6.0.0 * Code review fixes Co-authored-by: Felix Fontein <[email protected]> * Fix comments * Update changelogs/fragments/4320-nmcli-hairpin.yml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/4320-nmcli-hairpin.yml Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 53f6c68)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-4/53f6c68026b860c06547aee4deb533125005fb52/pr-4334
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4334 as merged into main (53f6c68).
SUMMARY
Change default hairpin mode for a bridge.
Plain nmcli/bridge tools defaults to no, but for some reason ansible
defaults to yes.
ISSUE TYPE
COMPONENT NAME
nmcli