Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4496/a8abb1a5 backport][stable-4] remove deprecated branch.unprotect() method in community.general.gitlab_branch #4528

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 19, 2022

This is a backport of PR #4496 as merged into main (a8abb1a).

SUMMARY

branch.unprotect() method has been deprecated on upstream python-gitlab/python-gitlab

refer to the commit: python-gitlab/python-gitlab@9656a16

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.gitlab_branch

ADDITIONAL INFORMATION

By using the latest python-gitlab, when delete branch, got error

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: AttributeError: 'ProjectBranch' object has no attribute 'unprotect'

…ab_branch (#4496)

* remove deprecated branch.protect method

* add changelog fragment

* Update changelogs/fragments/4496-remove-deprecated-method-in-gitlab-branch-module.yml

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a8abb1a)
@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug gitlab module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) source_control traceback labels Apr 19, 2022
@felixfontein felixfontein merged commit 90d31b9 into stable-4 Apr 19, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/a8abb1a5bfbb9e8a39c2b799d5ef485be073ffcc/pr-4496 branch April 19, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug gitlab module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) source_control traceback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants