Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated branch.unprotect() method in community.general.gitlab_branch #4496

Merged
merged 3 commits into from
Apr 19, 2022
Merged

remove deprecated branch.unprotect() method in community.general.gitlab_branch #4496

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
232fab7
remove deprecated branch.protect method
ethinx Apr 12, 2022
9e2ec5e
add changelog fragment
ethinx Apr 13, 2022
60f9e3d
Update changelogs/fragments/4496-remove-deprecated-method-in-gitlab-b…
ethinx Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/4496-remove-deprecated-method-in-gitlab-branch-module.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- git_branch - remove deprecated branch `protect`/`unprotect` method (https://github.com/ansible-collections/community.general/pull/4496).
ethinx marked this conversation as resolved.
Show resolved Hide resolved
1 change: 0 additions & 1 deletion plugins/modules/source_control/gitlab/gitlab_branch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def create_branch(self, branch, ref_branch):
return self.project.branches.create({'branch': branch, 'ref': ref_branch})

def delete_branch(self, branch):
branch.unprotect()
return branch.delete()


Expand Down