Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mysql db unsafe passwd #428

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Mysql db unsafe passwd #428

merged 3 commits into from
Jun 2, 2020

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented May 28, 2020 •
edited
Loading

SUMMARY

mysql_db: add unsafe_login_password parameter
Fixes: ansible/ansible#63955

One thing i'm worried about is that i can't reproduce Access denied described in ansible/ansible#63955 neither in my local environment nor in ansible CI tests.
Would be cool if anybody confirms that the problem exists.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_db

@ansibullbot
Copy link
Collaborator

cc @Alexander198961 @Xyon @bmalynovytch @bmildren @kurtdavis @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibullbot ansibullbot added affects_2.10 feature This issue/PR relates to a feature request integration tests/integration module module tests tests labels May 28, 2020
@Andersson007 Andersson007 mentioned this pull request May 28, 2020
Closed
@Andersson007
Copy link
Contributor Author

Andersson007 commented May 28, 2020 •
edited
Loading

Sanity failings are unrelated (the docker hub for CI is unavailable)
ERROR: Failed to pull docker image "quay.io/ansible/default-test-container:1.14".
thus,
ready_for_review

@Andersson007
Copy link
Contributor Author

Andersson007 commented May 28, 2020 •
edited
Loading

One thing i'm worried about is that i can't reproduce Access denied described in ansible/ansible#63955 neither in my local environment nor in ansible CI tests.
Would be cool if anybody confirms that the problem exists.

@Andersson007
Copy link
Contributor Author

cc @bmalynovytch @paulbadcock @winem

@Andersson007
Copy link
Contributor Author

Shippable passed.
third-party-check can be ignored for a while
ready_for_review

bmalynovytch
bmalynovytch approved these changes May 29, 2020
View reviewed changes
Copy link

@bmalynovytch bmalynovytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andersson007
Copy link
Contributor Author

@bmalynovytch thanks for reviewing!

@Andersson007 Andersson007 merged commit c2bf9ea into ansible-collections:master Jun 2, 2020
@Andersson007
Copy link
Contributor Author

merged #428 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmalynovytch bmalynovytch bmalynovytch approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request has_issue integration tests/integration module module tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql_db import fails with special characters in password
3 participants
@Andersson007 @ansibullbot @bmalynovytch