Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CentOS 8 from CI #4139

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Drop CentOS 8 from CI #4139

merged 1 commit into from
Jan 31, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Similar PRs for stable-1 and stable-2 are #4134 and #4135. For stable-3 and stable-4, hotfixes are in place: #4137 and #4138. I think it's better to drop it from main's CI as this will end up as the next major release of community.general.

See also ansible-collections/news-for-maintainers#3.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

CI

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR small_patch Hopefully easy to review labels Jan 31, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (third-party-check pipeline).

@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 31, 2022
@felixfontein felixfontein merged commit b444dc8 into ansible-collections:main Jan 31, 2022
@felixfontein felixfontein deleted the remove-centos8 branch January 31, 2022 21:33
@felixfontein
Copy link
Collaborator Author

@briantist thanks for reviewing this one as well!

@felixfontein
Copy link
Collaborator Author

It looks like this is necessary for stable-3 and stable-4 as well, the trick stopped working: see https://dev.azure.com/ansible/community.general/_build/results?buildId=36427&view=logs&j=aea58ae7-ea96-54ac-65fb-dfafeb177b41&t=1b4d8494-364a-5629-eade-b77421689812&l=878 and https://dev.azure.com/ansible/community.general/_build/results?buildId=36428&view=logs&j=aea58ae7-ea96-54ac-65fb-dfafeb177b41&t=1b4d8494-364a-5629-eade-b77421689812&l=879

@patchback
Copy link

patchback bot commented Feb 18, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/b444dc81a127d96f9e1560b3932237ccbcaf1c66/pr-4139

Backported as #4230

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Feb 18, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/b444dc81a127d96f9e1560b3932237ccbcaf1c66/pr-4139

Backported as #4231

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 18, 2022
@felixfontein @patchback
Drop CentOS 8 from CI. (#4139)
bd55555 
(cherry picked from commit b444dc8)
patchback bot pushed a commit that referenced this pull request Feb 18, 2022
@felixfontein @patchback
Drop CentOS 8 from CI. (#4139)
6fa1df5 
(cherry picked from commit b444dc8)
This was referenced Feb 18, 2022
Merged
Merged
felixfontein added a commit that referenced this pull request Feb 18, 2022
@patchback @felixfontein
Drop CentOS 8 from CI. (#4139) (#4230)
2473c08 
(cherry picked from commit b444dc8)

Co-authored-by: Felix Fontein <[email protected]>
felixfontein added a commit that referenced this pull request Feb 18, 2022
@patchback @felixfontein
Drop CentOS 8 from CI. (#4139) (#4231)
4b28b03 
(cherry picked from commit b444dc8)

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees
No one assigned
Labels
small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @briantist @ansibullbot