Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-1] added supports_check_mode=True to info/facts modules #3101

Merged
merged 2 commits into from
Jul 28, 2021
Merged

[stable-1] added supports_check_mode=True to info/facts modules #3101

merged 2 commits into from
Jul 28, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Backport of #3084 / #3095 to stable-1.

stable-1 had three more affected modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

many _info/_facts modules.

@felixfontein
[stable-2] added supports_check_mode=True to info/facts modules (ansi…
27f875a 
…ble-collections#3095)

* added supports_check_mode=True to info/facts modules (ansible-collections#3084)

* added supports_check_mode=True to info/facts modules

* added changelog fragment

* rolled back vertica_info

* rolled back utm_proxy_*_info

* updated changelog fragment with latest adjustments

* Update changelogs/fragments/3084-info-checkmode.yaml

Co-authored-by: Felix Fontein <[email protected]>

* added check mode to xenserver_facts + oneview_*_info

* added check mode to utm_proxy_*_info

* updated changelog

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 7da2c16)

* Also fix modules removed in 3.0.0.

Co-authored-by: Alexei Znamensky <[email protected]>
(cherry picked from commit 0fda418)
@felixfontein
Fix some more modules.
1056ef5
@felixfontein felixfontein requested a review from russoz July 28, 2021 05:53
@ansibullbot
Copy link
Collaborator

@felixfontein This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels Jul 28, 2021
@felixfontein felixfontein mentioned this pull request Jul 28, 2021
Merged
russoz
russoz approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 5336872 into ansible-collections:stable-1 Jul 28, 2021
@felixfontein felixfontein deleted the backport/stable-1/3084 branch July 28, 2021 07:59
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @russoz