Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_owner: add trust_input parameter #198

Merged
merged 4 commits into from
Apr 28, 2020
Merged

postgresql_owner: add trust_input parameter #198

merged 4 commits into from
Apr 28, 2020

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Related to #106
The PR:

  1. Adds the trust_input parameter to the postgresql_owner module
  2. Allows to pass values containing dots to the following parameters:
  • new_owner
  • reassign_owned_by
  • session_role
  • obj_name when obj_type is database/tablespace

Note:

  1. I added a lot of spaces to CI tests which were removed (unexpectedly) during the migration to the collections. I'll add also disappeared comments by separate PR later.
  2. Names of the other types like table or function can't contain dots right now because in the current design they are used to determine database/schema identifiers for these objects. We'll necessarily solve that somehow later.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/database/postgresql/postgresql_owner.py

@Andersson007
Copy link
Contributor Author

cc @andytom @kostiantyn-nemchenko @tcraxs @sebasmannem @raneq

@Andersson007 Andersson007 added database feature This issue/PR relates to a feature request labels Apr 17, 2020
@Andersson007
Copy link
Contributor Author

ready_for_review

@ansibullbot
Copy link
Collaborator

cc @Dorn- @amenonsen @jbscalia @matburt @nerzhul
click here for bot help

This was referenced Apr 20, 2020
Closed
Closed
@Andersson007
Copy link
Contributor Author

@raneq could you please also look at this, no rush

@Andersson007
Copy link
Contributor Author

/rebuild

@Andersson007 Andersson007 reopened this Apr 28, 2020
@Andersson007 Andersson007 merged commit 5febbca into ansible-collections:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request has_issue integration tests/integration module module tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andersson007 @ansibullbot